Fix bump-versions script and improve robustness #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvditto
changed the title
pvditto
added a commit
that referenced
this pull request
Oct 8, 2025
It's not possible to unignore files inside an ignored directory
pvditto
commented
Oct 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the bump-versions script to improve robustness and reliability. The script now uses explicit app configurations instead of file globbing, ensuring all expected files are found and updated.
- Replaced generic file globbing with explicit app-specific configurations
- Added mandatory lockfile updates with proper error handling
- Removed dry-run mode and improved logging with colored output
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/bump-versions.js | Complete rewrite with explicit app configs, enhanced error handling, and colored logging |
| react-native-expo/.gitignore | Updated iOS exclusions to be more specific (exclude Pods/ but not the entire ios/ directory) |
| .github/workflows/update-sdk-versions.yml | Simplified PR description template by removing detailed app list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pvditto
deleted the
pv/sdks-1704-quickstart-bump-version-script-failing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the script to bump versions didn't result in a PR that passed CI so this is adding logic to the script to update lock files and fail if any of the lockfile updates is not successful or the dependency to update can't be found.
Tested at #178